mirrors/tc_tea_rust
1
0
Fork 0
mirror of https://github.com/jixunmoe/tc_tea_rust synced 2026-03-08 04:29:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: use fold instead of for loops for zero check

Browse Source
This commit is contained in:
Jixun Wu
2021-12-29 13:42:55 +00:00
parent 825bd6d7be
commit 9c4737c2a9
1 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/stream_ext.rs
View File

@@ -1,3 +1,5 @@
use std::ops::BitOr;
pub trait StreamExt { pub trait StreamExt {
fn read_u32_be(&self, offset: usize) -> u32; fn read_u32_be(&self, offset: usize) -> u32;
fn write_u32_be(&mut self, offset: usize, value: u32); fn write_u32_be(&mut self, offset: usize, value: u32);
@@ -34,13 +36,7 @@ impl StreamExt for [u8] {
/// Attempts to do constant time comparison, /// Attempts to do constant time comparison,
/// but probably gets optimised away by llvm... lol /// but probably gets optimised away by llvm... lol
fn is_all_zeros(&self) -> bool { fn is_all_zeros(&self) -> bool {
let mut sum = 0; self.iter().fold(0u8, |acc, b| acc.bitor(b)) == 0
for b in self {
sum |= b;
}
return sum == 0;
} }
#[inline] #[inline]